From e435e27862298b55ff6578bf077c8627d789406a Mon Sep 17 00:00:00 2001
From: Jack Collins <6640905+jackmpcollins@users.noreply.github.com>
Date: Sun, 17 Nov 2024 01:58:50 -0800
Subject: [PATCH] Add CONTRIBUTING.md (#376)

* uv add --dev coverage

* Fix coverage report config

* Add Makefile

* Add CONTRIBUTING.md
---
 CONTRIBUTING.md | 10 ++++++++++
 Makefile        | 50 +++++++++++++++++++++++++++++++++++++++++++++++++
 pyproject.toml  |  7 ++++++-
 uv.lock         |  2 ++
 4 files changed, 68 insertions(+), 1 deletion(-)
 create mode 100644 CONTRIBUTING.md
 create mode 100644 Makefile

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..abdece8
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,10 @@
+# Contributing to magentic
+
+1. Fork and clone the repository
+2. [Install uv](https://docs.astral.sh/uv/getting-started/installation/)
+3. [Install pre-commit](https://pre-commit.com/#install)
+4. Run `make install` to install dependencies
+5. Run `make test` to run unit tests
+6. Run `make format` to format code
+7. Run `make lint` to lint code
+8. run `make docs` to build docs and `make docs-serve` to serve docs locally
diff --git a/Makefile b/Makefile
new file mode 100644
index 0000000..f020955
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,50 @@
+# Adapted from https://github.com/pydantic/logfire/blob/main/Makefile
+
+.DEFAULT_GOAL := all
+
+.PHONY: .uv  # Check that uv is installed
+.uv:
+	@uv --version || echo 'Please install uv: https://docs.astral.sh/uv/getting-started/installation/'
+
+.PHONY: .pre-commit  # Check that pre-commit is installed
+.pre-commit:
+	@pre-commit -V || echo 'Please install pre-commit: https://pre-commit.com/'
+
+.PHONY: install  # Install the package, dependencies, and pre-commit for local development
+install: .uv .pre-commit
+	uv sync --frozen
+	pre-commit install --install-hooks
+
+.PHONY: format  # Format the code
+format:
+	uv run ruff format
+	uv run ruff check --fix
+
+.PHONY: lint  # Lint the code
+lint:
+	uv run ruff check
+	uv run ruff format --check --diff
+
+.PHONY: typecheck  # Typecheck the code
+typecheck:
+	uv run mypy .
+
+.PHONY: test  # Run the tests
+test:
+	uv run pytest -vv
+
+.PHONY: testcov  # Run tests and generate a coverage report
+testcov: test
+	@echo "building coverage html"
+	uv run coverage html --show-contexts
+
+.PHONY: docs  # Build the documentation
+docs:
+	uv run mkdocs build
+
+.PHONY: docs-serve  # Build and serve the documentation
+docs-serve:
+	uv run mkdocs serve
+
+.PHONY: all
+all: format lint test
diff --git a/pyproject.toml b/pyproject.toml
index c67e5cf..52a5f31 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -34,6 +34,7 @@ dev = [
     "python-dotenv>=1.0.1",
     "ruff>=0.3",
     "pytest-recording>=0.13.2",
+    "coverage>=7.6.4",
 ]
 docs = [
     "blacken-docs>=1.16.0",
@@ -44,6 +45,10 @@ docs = [
 ]
 examples = ["ghapi>=1.0.5", "jupyter", "pandas>=2.2.1"]
 
+[tool.coverage.report]
+skip_covered = "true"
+show_missing = "true"
+
 [tool.mypy]
 check_untyped_defs = true
 disable_error_code = ["empty-body"]
@@ -65,7 +70,7 @@ venvPath = "."
 venv = ".venv"
 
 [tool.pytest.ini_options]
-addopts = "--cov=magentic --cov-report=term-missing --block-network"
+addopts = "--block-network --cov-report=html --cov-report=term --cov=magentic"
 asyncio_default_fixture_loop_scope = "function"
 asyncio_mode = "auto"
 markers = [
diff --git a/uv.lock b/uv.lock
index 9a171fc..0ea2dc5 100644
--- a/uv.lock
+++ b/uv.lock
@@ -1410,6 +1410,7 @@ litellm = [
 [package.dev-dependencies]
 dev = [
     { name = "anthropic" },
+    { name = "coverage" },
     { name = "inline-snapshot" },
     { name = "litellm" },
     { name = "logfire" },
@@ -1449,6 +1450,7 @@ requires-dist = [
 [package.metadata.requires-dev]
 dev = [
     { name = "anthropic" },
+    { name = "coverage", specifier = ">=7.6.4" },
     { name = "inline-snapshot", specifier = ">=0.14.0" },
     { name = "litellm" },
     { name = "logfire", specifier = ">=0.46.1,<0.50.0" },