Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Rails version in Gemspec #49

Open
mattconnolly opened this issue Feb 13, 2014 · 3 comments
Open

Specify Rails version in Gemspec #49

mattconnolly opened this issue Feb 13, 2014 · 3 comments

Comments

@mattconnolly
Copy link

Specifying which version of rails (e.g. "> 3.2.0" for 3.0.1 and "> 4.0.0" in 4.0.1) in the gem spec file would allow bundler to resolve which version of acts_as_commentable is appropriate for an application to use.

@mattconnolly
Copy link
Author

@jackdempsey
Copy link
Owner

Thanks for the thoughts Matt. I'm happy to consider a patch. I don't have much time for OSS these days unfortunately.

@mattconnolly
Copy link
Author

I'll send through a patch shortly. I'd like to offer a patch for the 3.0.1 version as well for the benefit of our rails 3.2 apps.

Can you please create a 3.x branch from the latest 3.0.1 gem release so I can make a pull request onto that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants