Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to choose corner travel order #18

Open
lordekeen opened this issue Aug 31, 2021 · 6 comments
Open

Add option to choose corner travel order #18

lordekeen opened this issue Aug 31, 2021 · 6 comments
Assignees

Comments

@lordekeen
Copy link

lordekeen commented Aug 31, 2021

First of all, thanks for the plugin, its awesome and really made my life easier since i don't have enough progmem to add anything else on Marlin.
I would like to suggest an option to choose the path between the corners, instead of only the "square" shape.
Something like this, lets assume the default order the head will move and probe is this one:
B------C
|---x---|
A------D
From A to B, C and D.
The user could then input the path he/she wants to override, like an X pattern: ACDB or ADBC.

@j-be
Copy link
Owner

j-be commented Aug 31, 2021

Hi, happy you like it 😃

If you want it permanently: you can just swap 2 corners in AutoBim's settings.

Else: I could imagine having something like a "Choose pattern" setting - should be fun to implement, too. The possible patterns are only ABCD and ACBD, or am I missing something?

@lordekeen
Copy link
Author

Sorry i didnt notice that i could swap corners already.
As for the patterns, i can visualize three, ABCD (square), ACBD (X) and ADBC (Z), changing the first corner would kind of rotate the pattern (like BCDA etc.).

@j-be j-be added the enhancement New feature or request label Sep 1, 2021
@j-be j-be self-assigned this Sep 1, 2021
@j-be
Copy link
Owner

j-be commented Sep 1, 2021

No worries 😄

You're right, Z is a valid unique pattern, too.

I'll add this to the roadmap, as I said: could be fun to implement.

@j-be
Copy link
Owner

j-be commented Oct 9, 2021

@lordekeen Things changed, and in regard to #13 and #14, which are both part of the v.0.1.11, the order just got a bit more complicated. I'm not sure if this makes any sense anymore. Thoughts?

@lordekeen
Copy link
Author

@j-be I've changed the order manually by editing the corners in the settings, maybe this functionality isnt really needed after all.

@j-be j-be removed the enhancement New feature or request label Oct 11, 2021
@j-be
Copy link
Owner

j-be commented Oct 11, 2021

@lordekeen Perfect. I'm leaving this issue open for reference, but do not expect any news on this for now. If something new comes up: feel free to comment here, or open a dedicated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants