Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Request] Lutris #983

Closed
contrarybaton60 opened this issue Oct 4, 2024 · 18 comments
Closed

[Package Request] Lutris #983

contrarybaton60 opened this issue Oct 4, 2024 · 18 comments

Comments

@contrarybaton60
Copy link
Contributor

To help us make adding applications quicker and easier, please try to follow the following two syntaxes.

If available on other sites

Important!

The two syntaxes mentioned above are enough for programs that can only be used from the command line.

However, for graphical programs and programs that require integration into the menu, and therefore a launcher, also add the following two pieces of information:


List of portable applications to add

Lutris

Notes

Considering Lutris is best used with programs like Wine, it may or may not be a good idea to add it as a dependency.

@ivan-hc
Copy link
Owner

ivan-hc commented Oct 4, 2024

well, from what I've seen and read, it seems not to be so "portable"

Istantanea_2024-10-04_02-21-31 png

but I was curious, so I downloaded and tested it

Istantanea_2024-10-04_02-20-49 png

and while you said...

Considering Lutris is best used with programs like Wine, it may or may not be a good idea to add it as a dependency.

...from the message above is clear that "wine" is not the only dependency needed

2024-10-04 02:19:55,420: Command 'vulkaninfo' not found on your system
2024-10-04 02:19:55,420: Command 'wine' not found on your system
2024-10-04 02:19:55,420: Command 'fluidsynth' not found on your system

this is out of the concept of "portable", this is instead a "portable" app https://github.com/ivan-hc/Steam-appimage

Also, I'm scared by this

Warning: You'll need to make sure you have the necessary dependencies for Python 3 (PyGObject3 and PyYAML).

Warning: Tools like Virtualenv or Pyenv are not supported. Please stick to the Python version provided by your OS. PyGObject code requires non Python dependencies to function correctly, it is highly recommended to satisfy those dependencies using your package manager.

Warning: If Lutris isn't installed from your package manager already, some features such as browser integration support will be missing. We recommend you keep the latest release version installed, even if you plan on using the development branch.

Warning: Please do not use setup.py install to install Lutris. It does not fully install lutris, some aspects are handled by the distribution's package manager. Additionally, Python's setuptools do not allow to easily uninstall software installed in such a manner. 

It's better if I ask the games/Steam expert.

@Samueru-sama how you see this? Trash or Pass?

@contrarybaton60
Copy link
Contributor Author

contrarybaton60 commented Oct 4, 2024

I already figured it was a bit of a stretch to add Lutris considering it's best used with a package manager and not on it's own. I'm pretty sure the .deb files provided by them do not have those restrictions the last time I used it, but I may be wrong.

@Samueru-sama
Copy link
Contributor

Lutris would need to be a conty AppImage like the Steam one as it has several dependencies.

I don't use lutris btw.

@ivan-hc
Copy link
Owner

ivan-hc commented Oct 4, 2024

Lutris would need to be a conty AppImage like the Steam one as it has several dependencies.

that's exactly what i was thinking, but there's a problem, as you say...

I don't use lutris btw.

Me neither. Steam is largely @Samueru-sama 's work, as he is a user of that program, and I don't even have an account. He is the one who test it, leading me in the right direction. I provided the base repository and he improved it, so much so that 80% of the work done in that repository is his merit.

On the contrary, for Lutris we do not have users who can personally test that AppImage. It would be easy for me to provide a base, but it is the finishing work that is important (testing games, program compatibility, configurations, lightweighting the package...).

@contrarybaton60 if I provided a base repository, would you be willing to collaborate?


PS: to be honest, I was trying to reduce the number of repositories, just to lighten my workload. And working on a new AppImage of a program I know little or nothing about, doesn't help.

@contrarybaton60
Copy link
Contributor Author

@contrarybaton60 if I provided a base repository, would you be willing to collaborate?

I can try, but I'm not really good with stuff, and due to school I can't really do much anyway... I'm gonna close this.

@ivan-hc
Copy link
Owner

ivan-hc commented Oct 4, 2024

I can try, but I'm not really good with stuff, and due to school I can't really do much anyway... I'm gonna close this.

ok, let me know

@ivan-hc ivan-hc mentioned this issue Oct 5, 2024
@Samueru-sama
Copy link
Contributor

@contrarybaton60
Copy link
Contributor Author

https://pasted.drakeerv.com/rYWcFx98

doesn't seem to

@lucasmz1
Copy link

what os are you using ? I need to know cause I'll make a rundown on it to undertand why the app doesn't spawn.

@contrarybaton60
Copy link
Contributor Author

Linux Mint 22 (based on Ubuntu 24.04, it likely has the same issue on there)

@lucasmz1
Copy link

Linux Mint 22 (based on Ubuntu 24.04, it likely has the same issue on there)

I've made a brand new one try it again 0.5.17 now it's using base jammy.you can report bugs on my github page if you want for we make this better.

@ivan-hc
Copy link
Owner

ivan-hc commented Nov 18, 2024

@lucasmz1 I'd better add your AppImage to the database, so others can contribute to bug reports.

But I ask you to add the scripts, or the code, or at least the instructions on the README.

Here in AM we have a policy to mark the installation scripts of applications coming from repositories without clear instructions on how they are compiled with a flag, "#spooky", so that during the installation the user is aware that the application is not only unofficial, but "could cause problems". And I know that is not your intention, I think you are a good person.

The idea of ​​marking the scripts of applications of this type was suggested to us in a long discussion with Probonopd, the creator of AppImage. You can see that entire discussion here #818

I will make an exception this time, but I ask you to add the code, or at least a documentation or enough information on your README.

You could ask @Twig6943 to help you, the other day he contacted me again and I finally added your application #1137

I want to help third-party packagers like you as much as possible to promote AppImage. But we need transparent methods and provide instructions that upstream developers can also consult. The more popular our projects are, the more they could be made official. But we need to provide the code. It's the only way to keep this format alive.

ivan-hc added a commit that referenced this issue Nov 18, 2024
ivan-hc added a commit to Portable-Linux-Apps/Portable-Linux-Apps.github.io that referenced this issue Nov 18, 2024
@contrarybaton60
Copy link
Contributor Author

Linux Mint 22 (based on Ubuntu 24.04, it likely has the same issue on there)

I've made a brand new one try it again 0.5.17 now it's using base jammy.you can report bugs on my github page if you want for we make this better.

It works! though GTK theming doesn't seem to work.
image

@Twig6943
Copy link
Contributor

Same here. I don't care about gtk theming tho
image

@lucasmz1
Copy link

Well does anyone know how to fix this icon issue.
I did everything I know.
steps I take
export XDG_DATA_DIRS=/home/lucas/Downloads/squashfs-root/usr/share/:/home/lucas/Downloads/squashfs-root/usr/share/mime && update-mime-database /home/lucas/Downloads/squashfs-root/usr/share/mime/
didn't work
disabled #GDK_PIXBUF_MODULEDIR=$APPDIR/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders
#GDK_PIXBUF_MODULE_FILE=$APPDIR/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders.cache
if enabled the app clash in some systems
another way I've copied new icon themes into the appdir didn't work
I've set GTK_THEME=Adwaita-dark
didn't work
any Ideias ? I am all ears!

@ivan-hc
Copy link
Owner

ivan-hc commented Nov 18, 2024

@lucasmz1 I had a similar issue with Handbrake and similar apps, it was enough to add gdk-pixbuf, librsvg and libdav to solve in all other appimages I had with the same issue

@lucasmz1
Copy link

@ivan-hc Thank you I wasn't awere about libdav. I'll try it out.

@contrarybaton60
Copy link
Contributor Author

Well does anyone know how to fix this icon issue. I did everything I know. steps I take export XDG_DATA_DIRS=/home/lucas/Downloads/squashfs-root/usr/share/:/home/lucas/Downloads/squashfs-root/usr/share/mime && update-mime-database /home/lucas/Downloads/squashfs-root/usr/share/mime/ didn't work disabled #GDK_PIXBUF_MODULEDIR=$APPDIR/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders #GDK_PIXBUF_MODULE_FILE=$APPDIR/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders.cache if enabled the app clash in some systems another way I've copied new icon themes into the appdir didn't work I've set GTK_THEME=Adwaita-dark didn't work any Ideias ? I am all ears!

I'm pretty sure you can set GTK_THEME to blank so it uses the system theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants