Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(net): Networking Crate #34

Merged
merged 16 commits into from
Aug 26, 2024
Merged

feat(net): Networking Crate #34

merged 16 commits into from
Aug 26, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 25, 2024

Description

Sets up a net crate based off of paradigmxyz/reth-exex-examples#15.

Metadata

Makes progress on #6

@refcell refcell self-assigned this Aug 25, 2024
@refcell refcell marked this pull request as draft August 25, 2024 17:59
@refcell refcell force-pushed the rf/feat/net branch 2 times, most recently from 9d6dc70 to b5ba1d7 Compare August 25, 2024 18:20
@shekhirin shekhirin added the C-enhancement New feature or request label Aug 25, 2024
@refcell refcell marked this pull request as ready for review August 25, 2024 23:09
@refcell refcell marked this pull request as draft August 25, 2024 23:10
@refcell
Copy link
Collaborator Author

refcell commented Aug 25, 2024

Converting back to draft, there's a few things I still missed

refcell
refcell commented Aug 26, 2024
View reviewed changes
crates/net/src/handler.rs Outdated Show resolved Hide resolved
@refcell refcell requested review from mattsse and emhane August 26, 2024 00:26
emhane
emhane reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! expecting tests for driver. unsure if cl protocols are in the right place in op-alloy, but probably this has already been agreed upon? wasn't aware that I am getting op-rs notifications ;)

crates/net/src/discovery.rs Outdated Show resolved Hide resolved
crates/net/src/op_enr.rs Outdated Show resolved Hide resolved
crates/net/src/op_enr.rs Outdated Show resolved Hide resolved
crates/net/src/handler.rs Outdated Show resolved Hide resolved
crates/net/src/driver.rs Outdated Show resolved Hide resolved
crates/net/src/discovery.rs Outdated Show resolved Hide resolved
crates/net/src/driver.rs Outdated Show resolved Hide resolved
crates/net/src/discovery.rs Outdated Show resolved Hide resolved
crates/net/src/discovery.rs Outdated Show resolved Hide resolved
crates/net/src/lib.rs Outdated Show resolved Hide resolved
merklefruit
merklefruit approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

crates/net/Cargo.toml Outdated Show resolved Hide resolved
crates/net/src/builder.rs Show resolved Hide resolved
crates/net/src/config.rs Outdated Show resolved Hide resolved
crates/net/src/handler.rs Outdated Show resolved Hide resolved
crates/net/src/handler.rs Outdated Show resolved Hide resolved
crates/net/src/types.rs Outdated Show resolved Hide resolved
crates/net/src/bootnodes.rs Outdated Show resolved Hide resolved
This was referenced Aug 26, 2024
Closed
Closed
Closed
@refcell refcell mentioned this pull request Aug 26, 2024
Closed
@refcell refcell marked this pull request as ready for review August 26, 2024 19:40
@refcell refcell merged commit 410d078 into main Aug 26, 2024
11 checks passed
@refcell refcell deleted the rf/feat/net branch August 26, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane left review comments

@merklefruit merklefruit merklefruit approved these changes

@Rjected Rjected Awaiting requested review from Rjected

@mattsse mattsse Awaiting requested review from mattsse

Assignees

@refcell refcell

Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refcell @merklefruit @emhane @shekhirin