Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review id generator class and if it's still needed #591

Open
ilongin opened this issue Nov 13, 2024 · 1 comment · May be fixed by #594
Open

Review id generator class and if it's still needed #591

ilongin opened this issue Nov 13, 2024 · 1 comment · May be fixed by #594
Assignees
@ilongin

Comments

@ilongin
Copy link
Contributor

ilongin commented Nov 13, 2024

We refactored "old" indexing / listing process by removing storages and partials tables. Id generators were mostly used there so probably we can remove that table and related codebase. It needs to be checked if it's used in some other place though.
@ilongin ilongin self-assigned this Nov 13, 2024
@ilongin
Copy link
Contributor Author

ilongin commented Nov 13, 2024

Looks like it's still used in one place in SaaS, but not used in datachain so it can be removed from this repo

@ilongin ilongin linked a pull request Nov 13, 2024 that will close this issue
Removing id generator #594
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilongin ilongin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing id generator iterative/datachain
1 participant
@ilongin