add xml support as xq (from python yq) #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello, I'm still doing havy tests on our servers, I let you know when it is ready for publishing |
Infinoid
reviewed
Aug 7, 2023
| @@ -61,13 +71,22 @@ type flagopts struct { | |||
| OutputCompact bool `short:"c" long:"compact-output" description:"output without pretty-printing"` | |||
| OutputIndent *int `long:"indent" description:"number of spaces for indentation"` | |||
| OutputTab bool `long:"tab" description:"use tabs for indentation"` | |||
| OutputYAML bool `long:"yaml-output" description:"output in YAML format"` | |||
| OutputYAML bool `short:"y" long:"yaml-output" description:"output in YAML format"` | |||
| OutputXML bool `short:"x" long:"xml-output" description:"output in XML format"` | |||
There was a problem hiding this comment.
(Note: I'm not the author of gojq, just an interested third party.)
I think it makes sense to add even more formats in the future (toml, msgpack, bson, etc), but this list of boolean flags will grow unmanageable.
What do you think about --input-format=xml and --output-format=xml instead of these format-specific parameters?
There was a problem hiding this comment.
Sure, looks to be a very good idea :)
|
If anyone is interested, a binary built called "xjq" is available here; https://github.com/momiji/xjq. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea it to add xml support the same as xq (installed with python yq).
It supports multiple xml inputs, that xq does not allow.
On read, much faster than original xq.
On write, many times faster than json2xml.
I'm opened to ideas.