Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сhange the display of inputs in constructors form #995

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

SleekMutt
Copy link
Contributor

@SleekMutt SleekMutt commented Nov 30, 2024

unknown_2024.11.30-19.15.mp4

solves #992

Code reviewers

Summary of issue

The form is unclear, because different sets of inputs are not separted.

Summary of change

Added fieldset and legend tags to separate group of inputs

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@SleekMutt SleekMutt requested a review from loqimean November 30, 2024 23:26
@SleekMutt SleekMutt self-assigned this Nov 30, 2024
@SleekMutt SleekMutt added the enhancement New feature or request label Nov 30, 2024
@SleekMutt SleekMutt merged commit f934abb into calculators-constructor Dec 1, 2024
7 checks passed
@SleekMutt SleekMutt deleted the constructors-form-redesign branch December 1, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants