Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SP: ) Fix type mismatch in FilterCell Component #2984

Open
SofiiaYevush opened this issue Dec 16, 2024 · 0 comments · May be fixed by #2996
Open

(SP: ) Fix type mismatch in FilterCell Component #2984

SofiiaYevush opened this issue Dec 16, 2024 · 0 comments · May be fixed by #2996
Assignees
@VKormylo
Labels
bug Something isn't working component design system task related to scss design system Frontend part priority: low

Comments

@SofiiaYevush
Copy link
Contributor

  • Missing filterEnum property in TableColumnProps, which is required for EnumFilter.
  • The filter property has an incorrect type.
  • The setFilter function's type doesn't align with the expected function signature for handling string[] in certain cases, leading to a type conflict.

File Path:
src/components/enhanced-table/filter-row/filter-cell/FilterCell.tsx

Code:
image

Problems:
image
@SofiiaYevush SofiiaYevush added bug Something isn't working Frontend part component priority: low design system task related to scss design system labels Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Project Backlog in SpaceToStudy Dec 16, 2024
@VKormylo VKormylo self-assigned this Dec 17, 2024
@VKormylo VKormylo linked a pull request Dec 18, 2024 that will close this issue
Fixed type mismatch in FilterCell component #2996
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VKormylo VKormylo

Labels
bug Something isn't working component design system task related to scss design system Frontend part priority: low
Projects
SpaceToStudy
Status: Project Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed type mismatch in FilterCell component ita-social-projects/SpaceToStudy-Client
2 participants
@VKormylo @SofiiaYevush