Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Habit Translations: ua fields doesn`t save #7319

Open
df7734 opened this issue Aug 7, 2024 · 0 comments · Fixed by #7898
Open

Habit Translations: ua fields doesn`t save #7319

df7734 opened this issue Aug 7, 2024 · 0 comments · Fixed by #7898
Assignees
@ChernenkoVitaliy
Labels
back-end This is label if this task is back-end Bug Create habit GreenCity
Milestone
Java S52.3

Comments

@df7734
Copy link
Collaborator

df7734 commented Aug 7, 2024

Environment: Windows 10, Swagger
Reproducible: always

Preconditions

The user is logged in

Steps to reproduce

habit-controller -> /habit/custom

Actual result

nameUa, descriptionUa, habitItemUa are not saved in DB

Expected result

all fields are saved in DB

Image Image
@df7734 df7734 added this to the Java S48.1 milestone Aug 7, 2024
@df7734 df7734 self-assigned this Aug 7, 2024
@df7734 df7734 added this to GreenCity Aug 7, 2024
@df7734 df7734 moved this to Sprint Backlog in GreenCity Aug 7, 2024
@df7734 df7734 mentioned this issue Aug 7, 2024
Closed
@HelenSotnik HelenSotnik modified the milestones: Java S48.1, Java S48.3 Aug 15, 2024
@HelenSotnik HelenSotnik modified the milestones: Java S48.3, Java S48.4 Aug 29, 2024
@KizerovDmitriy KizerovDmitriy modified the milestones: Java S49.2, Java S49.3 Sep 20, 2024
@softservedata softservedata modified the milestones: Java S49.3, Java S49.4 Sep 27, 2024
@softservedata softservedata modified the milestones: Java S49.4, Java S50.1 Oct 5, 2024
@softservedata softservedata modified the milestones: Java S50.3, Java S50.4 Oct 27, 2024
@softservedata softservedata modified the milestones: Java S51.3, Java S51.4 Nov 25, 2024
@ChernenkoVitaliy ChernenkoVitaliy self-assigned this Dec 2, 2024
@ChernenkoVitaliy ChernenkoVitaliy moved this from On Review to To Do in Java GreenCity Sprint Dec 2, 2024
@ChernenkoVitaliy ChernenkoVitaliy modified the milestones: Java S51.4, UI S52.1 Dec 2, 2024
@ChernenkoVitaliy ChernenkoVitaliy moved this from To Do to On Review in Java GreenCity Sprint Dec 3, 2024
@ChernenkoVitaliy ChernenkoVitaliy moved this from On Review to In Progress in Java GreenCity Sprint Dec 4, 2024
@ChernenkoVitaliy ChernenkoVitaliy modified the milestones: UI S52.1, Java S52.1 Dec 4, 2024
@softservedata softservedata modified the milestones: Java S52.1, Java S52.2 Dec 6, 2024
@ChernenkoVitaliy ChernenkoVitaliy mentioned this issue Dec 9, 2024
Merged
@ChernenkoVitaliy ChernenkoVitaliy moved this from In Progress to On Review in Java GreenCity Sprint Dec 9, 2024
@ChernenkoVitaliy ChernenkoVitaliy linked a pull request Dec 10, 2024 that will close this issue
Bugfix #7319 - Fixed incorrect saving for HabitTranslation for ua fields. #7898
Merged
@kryzanivska-nastya kryzanivska-nastya moved this from Bugs to Bugs in progress in GreenCity Dec 12, 2024
ChernenkoVitaliy added a commit that referenced this issue Dec 13, 2024
@ChernenkoVitaliy
Bugfix #7319 - Fixed incorrect saving for HabitTranslation for ua fie…
b5324f3 
…lds. (#7898)

* Fixed functionality of saving HabitTranslation in saveHabitTranslationListsToHabitTranslationRepo method in HabitServiceImpl;
Fixed necessary tests in HabitServiceImplTest;
Added getHabitTranslationDtoEnAndUa method in ModelUtils;
Added @notblank annotation in HabitTranslationDto for description, languageCode and name fields;
Added @Valid annotation for validation HabitTranslationDto into CustomHabitDtoRequest;
Added convertUa() and mapAllToList() methods into HabitTranslationMapper;
Added necessary nests in HabitTranslationMapperTests;

* Fixed sonar issues in HabitTranslationMapperTests;

* Moved strings for language codes in AppConstant;
Replced if/else to ObjectUtils.defaultNull;
Added test for HabitTranslationMapperTests to improve coverage;

* Formatted code in HabitTranslationMapperTests with formatter-maven-plagin;
@ChernenkoVitaliy ChernenkoVitaliy moved this from On Review to Done in Java GreenCity Sprint Dec 13, 2024
@github-project-automation github-project-automation bot moved this from Bugs in progress to Sprint Backlog in GreenCity Dec 13, 2024
@ChernenkoVitaliy ChernenkoVitaliy moved this from Sprint Backlog to Bugs in GreenCity Dec 13, 2024
@softservedata softservedata moved this from Bugs to Bugs Retesting in GreenCity Dec 18, 2024
@softservedata softservedata added the back-end This is label if this task is back-end label Dec 18, 2024
@ChernenkoVitaliy ChernenkoVitaliy moved this from Bugs Retesting to Bugs in progress in GreenCity Dec 19, 2024
@ChernenkoVitaliy ChernenkoVitaliy moved this from Bugs in progress to Bugs Retesting in GreenCity Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChernenkoVitaliy ChernenkoVitaliy

Labels
back-end This is label if this task is back-end Bug Create habit GreenCity
Projects
GreenCity
Status: Bugs Retesting
Milestone
Java S52.3
5 participants
@softservedata @ChernenkoVitaliy @df7734 @HelenSotnik @KizerovDmitriy