Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bench] 競技者VMのGIPを受け取る環境変数をfixする #1172

Closed
ryoha000 opened this issue Aug 15, 2021 · 3 comments · Fixed by #1278
Closed

[bench] 競技者VMのGIPを受け取る環境変数をfixする #1172

ryoha000 opened this issue Aug 15, 2021 · 3 comments · Fixed by #1278
Assignees
Labels

Comments

@ryoha000
Copy link
Contributor

ポータルチームから受け取り次第

@ShotaKitazawa
Copy link
Member

ShotaKitazawa commented Aug 16, 2021

先週のポータル定例にて ISUXBENCH_ALL_ADDRESSES になると共有を受けてますが、以下に追記されるの待ちです

@ShotaKitazawa
Copy link
Member

まだ isucon11-portal 側が import 出来る形になってないので pending

https://github.com/isucon/isucon11-portal/blob/976b15fa7a0307d741aa7bb4fbe2a2d0ea4a09c1/go.mod#L1

@ShotaKitazawa
Copy link
Member

isucon11-portal 側のパッケージ名を変えるのは isucon/isucon11-portal#167 に issue 化し、今回環境変数はひとまず bench/main.go から直接読むようにする事になった。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants