Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We Should Fix Traditional Makefile Compilation #15

Open
xrq-phys opened this issue Aug 12, 2020 · 0 comments
Open

We Should Fix Traditional Makefile Compilation #15

xrq-phys opened this issue Aug 12, 2020 · 0 comments

Comments

@xrq-phys
Copy link
Collaborator

xrq-phys commented Aug 12, 2020

An easy workaround would be:

In src/StdFace/makefile_StdFace:

StdFace_OBJS = StdFace_main.o StdFace_ModelUtil.o
Lattice_OBJS = SquareLattice.o ChainLattice.o TriangularLattice.o \
        HoneycombLattice.o Ladder.o Kagome.o Orthorhombic.o FCOrtho.o \
        Pyrochlore.o Wannier90.o setmemory.o # <<< Add this

In src/ComplexUHF/makefile_uhf:

include ../make.sys

SFMT = ../sfmt/SFMT.o

OBJS = \
../common/setmemory.c \ # <<< Add this
cal_energy.o \
diag.o \
green.o \
initial.o \
makeham.o \
matrixlapack.o \
output.o \
readdef.o \
UHFmain.o

and delete all lines related to mfmemory.c.

To be honest, after experiencing many CMake-related problems, I'm beginning to doubt that CMake might not be a good toolset for us:

  • CMake is designed to work on both *nix and Windows but we only need previous one (and this CMakeFiles.txt won't work on Windows);
  • CMake's quite obstinate when doing cross-compilation but we need flexible cross-compiling on, e.g. Fugaku's assessing environment (「富岳」前期評価環境);
  • CMake's also stubborn on BLAS/LAPACK finding which might make it hard to feed alternative implementations (e.g. flame/BLIS).

As a result, I guess we should at least continue to support old makefile and remove that makefile is deprecated warning.
BTW adding -x permission to mVMCconfig.sh might also be a good idea :)

Best,
RuQing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant