Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Generic Attributes Extension for advanced markdown syntax support #944

Open
3 tasks
wisetc opened this issue Feb 17, 2023 · 2 comments
Open
3 tasks
Labels
feature needs-decision Architectural/Behavioral decision by maintainers needed server (Python) server code
Milestone

Comments

@wisetc
Copy link

wisetc commented Feb 17, 2023

Checklist

  • I am running the latest version. Installing Isso from GitHub from the master branch does not fix my issue
  • I have checked the troubleshooting guide
  • I have searched the open issues, but my issue has not already been reported

What is not working?

markdown syntax which produce a tag, missing the data-xxx property

How can one reproduce this issue?

[baidu](https://www.baidu.com){data-link-name='baidu'}

And if I am using the <a href="https://www.baidu.com" data-link-name="baidu">baidu</a>, it also did not work.

What should I do?

@ix5
Copy link
Member

ix5 commented Feb 17, 2023

Isso's markdown parser is misaka, which doesn't support custom markdown attributes.

Since misaka says the following about their project, it might be time to revisit which parser we use going forward:

WARNING: Misaka is not being maintained anymore. I've not been able to find time to to properly maintain this project. Consider using mistletoe or Mistune.

@ix5 ix5 added server (Python) server code feature needs-decision Architectural/Behavioral decision by maintainers needed labels Feb 17, 2023
@ix5 ix5 added this to the backburner milestone Feb 17, 2023
@wisetc
Copy link
Author

wisetc commented Feb 17, 2023

get it, thank you @ix5

@ix5 ix5 changed the title Can you add Generic Attributes Extension to the comment system to support advanced markdown syntax Feature request: Generic Attributes Extension for advanced markdown syntax support Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature needs-decision Architectural/Behavioral decision by maintainers needed server (Python) server code
Projects
None yet
Development

No branches or pull requests

2 participants