Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix filters based on their type #216

Open
stufisher opened this issue Sep 28, 2022 · 0 comments
Open

Prefix filters based on their type #216

stufisher opened this issue Sep 28, 2022 · 0 comments
Labels
code quality

Comments

@stufisher
Copy link
Collaborator

stufisher commented Sep 28, 2022 •
edited
Loading

Currently pyisby.filters exports a bunch of Query parameter variables.

def proposalId
def sessionId
....

We could prefix these with query to be clear what they represent.
Or we can assume they are query parameters, and prefix new methods

def pathProposalId
...
@stufisher stufisher changed the title Rename filters based on their type Prefix filters based on their type Sep 28, 2022
@stufisher stufisher mentioned this issue Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stufisher