Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Endpoint webhook ensuring unique MAC addresses #187

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Add Endpoint webhook ensuring unique MAC addresses #187

merged 3 commits into from
Nov 28, 2024

Conversation

damyan
Copy link
Member

@damyan damyan commented Nov 27, 2024

Fixes #183

@github-actions github-actions bot added enhancement New feature or request size/XL labels Nov 27, 2024
@damyan damyan requested a review from afritzler November 27, 2024 10:20
afritzler
afritzler requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damyan for the PR. Just some minor things.

internal/webhook/v1alpha1/endpoint_webhook.go Outdated Show resolved Hide resolved
internal/webhook/v1alpha1/endpoint_webhook.go Outdated Show resolved Hide resolved
internal/webhook/v1alpha1/endpoint_webhook.go Outdated Show resolved Hide resolved
internal/webhook/v1alpha1/endpoint_webhook_test.go Outdated Show resolved Hide resolved
internal/webhook/v1alpha1/endpoint_webhook_test.go Outdated Show resolved Hide resolved
internal/webhook/v1alpha1/endpoint_webhook_test.go Outdated Show resolved Hide resolved
internal/webhook/v1alpha1/endpoint_webhook_test.go Outdated Show resolved Hide resolved
@damyan
Implement review findings
5f3dfbd 
- improve wording
- fix typos
@damyan damyan force-pushed the enh/endpoint-webhook branch from 39f47ee to 5f3dfbd Compare November 27, 2024 12:34
@damyan damyan requested a review from afritzler November 27, 2024 12:35
@damyan
Copy link
Member Author

damyan commented Nov 27, 2024

Thanks @damyan for the PR. Just some minor things.

Oh my, a lot of typos in there. Should be gone now, thanks for finding

@afritzler afritzler changed the title Add Endpoint webhook validating unique MAC addresses Add Endpoint webhook ensuring unique MAC addresses Nov 28, 2024
@afritzler afritzler merged commit efee1bf into main Nov 28, 2024
9 checks passed
@afritzler afritzler deleted the enh/endpoint-webhook branch November 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Admission Webhook to Ensure Unique MAC Address for Endpoint CRD
2 participants
@damyan @afritzler