Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additionalDataV2 worker hash #663

Open
afritzler opened this issue Nov 18, 2024 · 2 comments
Open

Add support for additionalDataV2 worker hash #663

afritzler opened this issue Nov 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@afritzler
Copy link
Member

afritzler commented Nov 18, 2024

Summary

In order to support the new NewWorkerPoolHash Gardener feature gate we need to implement the additionalDataV2 in the worker hash calculation: https://github.com/ironcore-dev/gardener-extension-provider-ironcore/blob/main/pkg/controller/worker/machines.go#L199

/cc @adenitiu

@afritzler afritzler added the enhancement New feature or request label Nov 18, 2024
@afritzler afritzler moved this from Todo to In Progress in Integration Nov 27, 2024
@ushabelgur
Copy link
Contributor

ushabelgur commented Nov 28, 2024

As I checked from other providers additionalDataV2 values is calculated out of WorkerConfig.
For eg.
https://github.com/gardener/gardener-extension-provider-aws/blob/6285bce8258f8ea2887bf88402232b4214be8698/pkg/controller/worker/machines.go#L402
https://github.com/gardener/gardener-extension-provider-azure/blob/33ff443a9d20029a1bec543a494acd9170b95713/pkg/controller/worker/machines.go#L535

And some providers are simply copying same data as additionalDataV1 or they passing empty slice and putting everything in one single additionlaData .
For eg.
https://github.com/gardener/gardener-extension-provider-openstack/blob/31a90d1490a244770e27d69aa6d925859060e433/pkg/controller/worker/machines.go#L281
https://github.com/gardener/gardener-extension-provider-gcp/blob/c4a3f4f942d880e13eee7dbe0757d1db22b22a0c/pkg/controller/worker/machines.go#L362

At this moment the ironcore extension does not have any worker specific provider configuration. Should we introduce this WorkerConfig in Ironcore and what fields we want to put here? (eg. https://github.com/gardener/gardener-extension-provider-gcp/blob/master/pkg/apis/gcp/types_worker.go#L16) or we just pass empty slice here ?

cc @afritzler @balpert89

@ushabelgur
Copy link
Contributor

At this moment the ironcore extension does not have any worker specific provider configuration. As discussed in synch call, we wont be fixing this issue as of now.

@ushabelgur ushabelgur added the wontfix This will not be worked on label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
Status: In Progress
Development

No branches or pull requests

2 participants