Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#641] avoid unnecessary SyntaxError message #661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[#641] avoid unnecessary SyntaxError message #661

wants to merge 1 commit into from

Conversation

d-w-moore
Copy link
Collaborator

Other parts of the error dump (detailng three levels of stacked exceptions) already give enough complexity for the troubleshooter to deal with, so this change helps us by avoiding a fourth: a SyntaxError easily avoided by jumping around the situation we found ourselves in with #641, and that was doing an eval on a string that could be empty. Bad progammer!

korydraughn
korydraughn reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the change is for testing, I think this is good to go.

Let's get an issue number on the commit message and then we'll give the signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-w-moore @korydraughn