Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a test to demonstrate xml_mode allows setting nonprintable AVUs #659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create a test to demonstrate xml_mode allows setting nonprintable AVUs #659

wants to merge 2 commits into from

Conversation

d-w-moore
Copy link
Collaborator

@d-w-moore d-w-moore commented Nov 13, 2024 •
edited
Loading

Check that irods.helpers.xml_mode (#586) addresses #582

@d-w-moore d-w-moore changed the title xml_mode->meta Create a test to demonstrate xml_mode allows setting nonprintable AVUs Nov 13, 2024
@trel
Copy link
Member

trel commented Nov 13, 2024

does this test need assertions?

@d-w-moore d-w-moore mentioned this pull request Nov 13, 2024
Open
@d-w-moore
Copy link
Collaborator Author

Test passes, and I also confirmed the original error is produced when xml_mode is non-importable.

korydraughn
korydraughn reviewed Nov 13, 2024
View reviewed changes
irods/test/meta_test.py Outdated Show resolved Hide resolved
irods/test/meta_test.py Outdated Show resolved Hide resolved
irods/test/meta_test.py Show resolved Hide resolved
irods/test/meta_test.py Outdated Show resolved Hide resolved
@trel
Copy link
Member

trel commented Nov 13, 2024

please don't force push

@trel
Copy link
Member

trel commented Nov 13, 2024

force pushes mean we can't see the diff.

alanking
alanking reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy reports a couple of unused imports. Otherwise, seems fine.

irods/test/meta_test.py Outdated Show resolved Hide resolved
irods/test/meta_test.py Show resolved Hide resolved
alanking
alanking reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. This seems like it's ready for squashing to me

@korydraughn
Copy link
Contributor

Agreed.

@d-w-moore
Copy link
Collaborator Author

Squashed.

d-w-moore
d-w-moore commented Nov 25, 2024
View reviewed changes
Copy link
Collaborator Author

@d-w-moore d-w-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if the test should verify the metadata got into the catalog

@korydraughn
Copy link
Contributor

Yes please.

@d-w-moore
Copy link
Collaborator Author

Done.

@korydraughn
Copy link
Contributor

Looks good. Squash it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanking alanking alanking left review comments

@korydraughn korydraughn korydraughn left review comments

@trel trel trel left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-w-moore @trel @korydraughn @alanking