Escape PAM special characters properly #656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the approach to escaping characters from the set: [@&;=] that iRODS historically has had problems accommodating in PAM passwords in the past. Presently, for iRODS 4.2 and 4.3 we only need to consider ";" and "=" as problematic characters, due to the conflict with the use of those characters in the KVP-formatted context parameter when the AUTH_PLUG_REQ_AN api is used.
Also correct matching auth scheme names for PAM. We now compare to "pam"* so that iRODS 4.2 and 4.3 can both pass the tests.
trel
reviewed
Nov 6, 2024
trel
reviewed
Nov 6, 2024
|
It looks like these changes address our issue #650 . |
|
Very good - thank you @llp-rug. |
This is for more consistent naming of things across source code bases.
alanking
reviewed
Nov 22, 2024
|
Also please eyeball Codacy |
Co-authored-by: Alan King <[email protected]>
alanking
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix character escaping.
For servers in the 4.2 and 4.3 series,
@and&no longer need escaping. We shall still escape=and;due to their use as part of kvp (key-value pair) strings in the iRODS protocol.