Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[59] Update README for yum build instructions #63

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

JustinKyleJames
Copy link

Several Updates:

  1. Updated versions of clang and cmake.
  2. Added installation for make and epel-release.

@trel
Copy link
Member

trel commented Mar 30, 2023

4-2-stable still uses clang6 and cmake3.11 and jansson i think...

@korydraughn
Copy link

I think we removed the dependency on jansson. It's possible some other 4.2 project still relies on it.

@JustinKyleJames
Copy link
Author

JustinKyleJames commented Mar 30, 2023

I tested with clang6 and cmake3.11 and updated this pull request accordingly.

I added the jansson package install back in because it is in the CMakeLists.txt. I don't believe this is required and have opened an issue (#64) on it but I don't think that is necessary for this pull request.

Note that this has already been removed and tested in 4.3.

@JustinKyleJames
Copy link
Author

JustinKyleJames commented Mar 30, 2023

Also note that the irods-dev* in the following lines needs to be altered for the specific version. If you just do it as is it will upgrade to 4.3 which is not what a person would want who is building for 4.2.x.

sudo apt-get -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-dev irods-runtime
sudo yum -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-devel irods-runtime rpm-build

Should we update these to the following:

sudo apt-get -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-dev=<version> irods-runtime=<version>
sudo yum -y install irods-externals-cmake3.11.4-0 irods-externals-clang6.0-0 irods-externals-jansson2.7-0 irods-devel-<version> irods-runtime-<version> rpm-build

Maybe a note that if you are building for the latest irods version the irods-dev(el) doesn't need a version attached.

@JustinKyleJames
Copy link
Author

I updated the README to have the version selected for irods-dev(el) and irods-runtime.

Note that from debian I had to add a wildcard since the OS version is in the version string.

@trel
Copy link
Member

trel commented Mar 30, 2023

i see it.

does the asterisk work as expected/designed? from a repo?

@JustinKyleJames
Copy link
Author

JustinKyleJames commented Mar 31, 2023 via email

@trel
Copy link
Member

trel commented Mar 31, 2023

got it - please squash to one.

@JustinKyleJames
Copy link
Author

got it - please squash to one.

done

@trel
Copy link
Member

trel commented Apr 8, 2023

good good - please # it.

@trel
Copy link
Member

trel commented Jul 7, 2023

@JustinKyleJames please # this commit

@JustinKyleJames
Copy link
Author

I just pounded this. Sorry about the delay.

@trel
Copy link
Member

trel commented Aug 2, 2023

merging.

@trel trel merged commit 0a2ef56 into irods:4-2-stable Aug 2, 2023
@JustinKyleJames JustinKyleJames deleted the issue_59_42stable branch August 2, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants