-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[59] Update README for yum build instructions #63
Conversation
4-2-stable still uses clang6 and cmake3.11 and jansson i think... |
I think we removed the dependency on jansson. It's possible some other 4.2 project still relies on it. |
a082041
to
b60b874
Compare
I tested with clang6 and cmake3.11 and updated this pull request accordingly. I added the jansson package install back in because it is in the CMakeLists.txt. I don't believe this is required and have opened an issue (#64) on it but I don't think that is necessary for this pull request. Note that this has already been removed and tested in 4.3. |
Also note that the irods-dev* in the following lines needs to be altered for the specific version. If you just do it as is it will upgrade to 4.3 which is not what a person would want who is building for 4.2.x.
Should we update these to the following:
Maybe a note that if you are building for the latest irods version the irods-dev(el) doesn't need a version attached. |
I updated the README to have the version selected for irods-dev(el) and irods-runtime. Note that from debian I had to add a wildcard since the OS version is in the version string. |
i see it. does the asterisk work as expected/designed? from a repo? |
Yes, it does.
…________________________________
From: Terrell Russell ***@***.***>
Sent: Thursday, March 30, 2023 2:51 PM
To: irods/irods_client_globus_connector ***@***.***>
Cc: James, Justin Kyle ***@***.***>; Author ***@***.***>
Subject: Re: [irods/irods_client_globus_connector] [59] Update README for yum build instructions (PR #63)
i see it.
does the asterisk work as expected/designed? from a repo?
—
Reply to this email directly, view it on GitHub<#63 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACXBOHQNCTWI4JD4472O2GDW6XI4RANCNFSM6AAAAAAWNKYAIQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
got it - please squash to one. |
2e95281
to
9238969
Compare
done |
good good - please # it. |
@JustinKyleJames please # this commit |
9238969
to
d7cfd71
Compare
I just pounded this. Sorry about the delay. |
merging. |
Several Updates: