Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_psr() fails if filter_dict=None #11

Open
paulthebaker opened this issue Feb 8, 2019 · 0 comments
Open

filter_psr() fails if filter_dict=None #11

paulthebaker opened this issue Feb 8, 2019 · 0 comments

Comments

@paulthebaker
Copy link
Collaborator

paulthebaker commented Feb 8, 2019

Setting filter_dict=None should be a valid use case to run a frequency filter, but no flag filters. It might be worth changing the name of filter_dict to flag_filter or similar.

Currently, the function starts with flag_keep = [] and if filter_dict=None this is never updated and no TOAs are kept.

Workaround is pass a filter that all toas will pass:

filter_dict={'pta':['NANOGrav', 'PPTA', 'EPTA']}
paulthebaker added a commit that referenced this issue May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant