Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused addrs from peerstore #128

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Remove unused addrs from peerstore #128

merged 3 commits into from
Sep 27, 2023

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Sep 27, 2023

Remove unused addrs from peerstore to prevent addresses that are no longer valid from continuing to be used.

Confirmed this to fix a publisher address that was no longer valid and should have been replaced by a different address.

Fixes #127

Update non-critical log messages to log at debug level.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c886fd4) 61.32% compared to head (07c2bf5) 61.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   61.32%   61.61%   +0.28%     
==========================================
  Files          57       57              
  Lines        4913     4929      +16     
==========================================
+ Hits         3013     3037      +24     
+ Misses       1573     1566       -7     
+ Partials      327      326       -1     
Files Coverage Δ
dagsync/subscriber.go 69.02% <88.00%> (+0.78%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remove unused addrs from peerstore to prevent addresses that are no longer valid from continuing to be used.

Fixes #127

Update non-critical log messages to log at debug level.
@gammazero gammazero merged commit 262133f into main Sep 27, 2023
7 checks passed
@gammazero gammazero deleted the clear-peerstore branch September 27, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear previous addrs from peerstore before adding new
2 participants