fix: avoid internal requests for action icons #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change checks if icon changed, and sets it only when it is needed, removing overhead of redraw and internal requests. Context: every time peer count was updated, the browser action icon got set, which caused unnecessary internal request for PNG assets on Chrome. Chrome does not support SVG in browser action, so we also had to compute the path of PNG (it is now memoized).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Motivation
Context: every time peer count was updated, the browser action icon got set,
which caused unnecessary internal request for PNG assets every 3 seconds:
This change mostly makes request logs in Network tab less noisy in Brave (#716), but is also related to addressing #721: next step will be to stop polling API status every 3 seconds.