Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MV3 Beta Bugs] browserAction updates broken in Firefox #1274

Closed
lidel opened this issue Sep 13, 2023 · 1 comment · Fixed by #1275
Closed

[MV3 Beta Bugs] browserAction updates broken in Firefox #1274

lidel opened this issue Sep 13, 2023 · 1 comment · Fixed by #1275
Assignees
@whizzzkid
Labels
area/firefox Issues related to Mozilla Firefox area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs

Comments

@lidel
Copy link
Member

lidel commented Sep 13, 2023

@whizzzkid found this while reviewing #1182 (will be filling standalone issues as I go)

Tested MV3 from #1182 in latest Firefox nightly (119.0a1 (2023-09-13)):

$ npm run dev-build && npm run firefox:nightly

Onboarding It works as expected, After I grant permission to companion it connects to RPC just fine, but the browserAction icon remains "offline" due to error below:

2023-09-13_19-38
2023-09-13_19-36
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization mv3-beta-bugs labels Sep 13, 2023
@lidel lidel added area/MV3 Issues related to Manifest V3 version area/firefox Issues related to Mozilla Firefox labels Sep 13, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Sep 14, 2023
@whizzzkid whizzzkid mentioned this issue Sep 14, 2023
Merged
@whizzzkid whizzzkid moved this from Needs Grooming to In Review in IPFS-GUI (PL EngRes) Sep 14, 2023
@whizzzkid
Copy link
Contributor

fixed in #1275

@github-project-automation github-project-automation bot moved this from In Review to Done in IPFS-GUI (PL EngRes) Sep 17, 2023
@whizzzkid whizzzkid removed the need/triage Needs initial labeling and prioritization label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
area/firefox Issues related to Mozilla Firefox area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mv3): FF Browser Action ipfs/ipfs-companion
2 participants
@lidel @whizzzkid