fix: remove webtransport from default transports #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
requested changes
Nov 7, 2024
SgtPooki
approved these changes
Nov 11, 2024
|
@achingbrain Any thoughts on this? |
|
This makes me a bit 😭 but I don't how else we can give users a good experience otherwise right now. |
achingbrain
approved these changes
Nov 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WebTransport is still not working reliably across different browsers. Moreover, the go-libp2p implementation needs to be updated to meet newer revisions of the spec.
As we discussed during Helia WG, the most sensible thing for now is to remove WebTransport from the default transports.
Related to libp2p/js-libp2p#2572
Change checklist