Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tls to default delegated routing filters #670

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Oct 30, 2024

Description

  • fix: add tls to all default filters
  • chore: avoid duplication of filters

Notes & open questions

Should we just move these defaults to the Delegated Routing client?

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@2color 2color requested a review from a team as a code owner October 30, 2024 13:18
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Youll need to add the browser default to the package.json to ensure its picked up

@2color
Copy link
Member Author

2color commented Oct 30, 2024

Youll need to add the browser default to the package.json to ensure its picked up

We're already doing that in the @helia/routers pacakge:

"./dist/src/utils/delegated-http-routing-defaults.js": "./dist/src/utils/delegated-http-routing-defaults.browser.js"

Is it necessary also here?

@2color 2color requested a review from achingbrain October 31, 2024 09:39
@achingbrain
Copy link
Member

Should we just move these defaults to the Delegated Routing client?

Probably not? The defaults here are tied to the libp2p configuration (as in, no point adding the TLS filter if you've not got @libp2p/tls in your setup) which would be hard to predict in the delegated routing client, probably best to just let people configure it for their needs.

@2color 2color merged commit aecac3d into main Nov 4, 2024
19 checks passed
@2color 2color deleted the fix/update-delegated-default branch November 4, 2024 11:19
@achingbrain achingbrain mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants