Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] AGP order section requirement is inconsistent #562

Open
IvoTod opened this issue Oct 30, 2023 · 0 comments
Open

[BUG] AGP order section requirement is inconsistent #562

IvoTod opened this issue Oct 30, 2023 · 0 comments
Assignees
@IvoTod
Labels
bug Something isn't working

Comments

@IvoTod
Copy link
Collaborator

IvoTod commented Oct 30, 2023

What happened:
Due to WDAE AGP views requiring order to be in the configuration in order to not error, we made the order section required in the schema, but there are tests and cases where the code does not get stopped by cerberus' validation.
What you expected to happen:
Any AGP code should be stopped early by cerberus validation.
@IvoTod IvoTod added the bug Something isn't working label Oct 30, 2023
@IvoTod IvoTod self-assigned this Oct 30, 2023
IvoStefanov added a commit that referenced this issue Nov 10, 2023
@IvoStefanov
test agp creation with valid data and no mocks
e3f9953 
#562
IvoStefanov added a commit that referenced this issue Nov 16, 2023
@IvoStefanov
test agp creation with valid data and no mocks
59985bd 
#562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvoTod IvoTod

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IvoTod