Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unused old method for REST API client #533

Open
IvoTod opened this issue Sep 13, 2023 · 0 comments
Open

[BUG] Unused old method for REST API client #533

IvoTod opened this issue Sep 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@IvoTod
Copy link
Collaborator

IvoTod commented Sep 13, 2023

What happened:
@livovachkov was writing tests for variant queries and stumbled upon the post_query_variants_download method wdae/wdae/remote/rest_api_client.py. It attempts to get the variants through a download requests and then incorrectly tries to interpet the CSV stream response as a JSON list stream and errors. Upon further inspection, the method is currently unused and has been left in this unusable and useless state for a long time.

What you expected to happen:
The method should at the very least work or be removed if it is deemed unnecessary.

@IvoTod IvoTod added the bug Something isn't working label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant