Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project fails when loaded into VS #8

Open
baronfel opened this issue Feb 22, 2022 · 2 comments
Open

Project fails when loaded into VS #8

baronfel opened this issue Feb 22, 2022 · 2 comments

Comments

@baronfel
Copy link
Collaborator

When 0.1.2 is loaded into VS, users get the following stack:

2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018: The "Ionide.KeepAChangelog.Tasks.ParseChangeLogs" task failed unexpectedly.
2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'FSharp.Core, Version=4.4.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018: File name: 'FSharp.Core, Version=4.4.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018:    at Ionide.KeepAChangelog.Parser.parseChangeLog(FileInfo file)
2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018:    at KeepAChangelog.Tasks.ParseChangelogs.Execute() in /_//src/Ionide.KeepAChangelog.Tasks/Library.fs:line 117
2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()
2>C:\Users\david\.nuget\packages\ionide.keepachangelog.tasks\0.1.2\build\Ionide.KeepAChangelog.Tasks.targets(14,9): error MSB4018: 
...

IMO this is because we need to support full-framework MSBuild targets. The vs-support branch tracks this need.

@baronfel
Copy link
Collaborator Author

So far I've:

  • Added a net472 target
  • fixed packaging/targets paths to load the correct TFM based on MSBuild runtime
  • but now I'm hitting FSharp.Core binding redirect issues (maybe need to generate app configs?)

@baronfel
Copy link
Collaborator Author

Alternative idea - for net472 don't bundle fsharp.core at all and see if the ambient one from VS is picked up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant