-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to FCS 40 #36
Comments
Wouldn't be a good idea to keep FCS used here in sync with FCS version in Fantomas? Had problems using different versions Heck, I even thought about including FsAst into Fantomas (maybe in a |
yes, that's precisely why the associated MR is in draft state still :p |
@nojaf speaking of, any idea when the first prereleases of fantomas with FCS40 will drop? I'm also looking forward to those for FSAC itself |
Hey, yeah about that 🙈. I'm currently pitching the idea of having a patch release for FCS 40. There is one thing that just really doesn't produce AST anymore. And another fix that would allow for a huge clean up in Fantomas. |
the thing is, even that proposed patch release would be a major version bump (due to api breakages). so it sounds like you're suggesting skipping 40 entirely? |
It has crossed my mind, to be honest. The daemon experiment could potentially resolve the hurdle in FSAC. |
https://www.nuget.org/packages/FSharp.Compiler.Service/40.0.1-preview.21352.5 just dropped, I'll check over the weekend if I can publish the first alpha. |
We're blocked from doing this until fantomas has a version that supports FCS 40. There's a branch with that work, but no prerelease/stable quite yet.
The text was updated successfully, but these errors were encountered: