Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console colour not being reset before fsharp-analyzers cli tool exits? #215

Closed
Numpsy opened this issue Jul 21, 2024 · 1 comment · Fixed by #216
Closed

Console colour not being reset before fsharp-analyzers cli tool exits? #215

Numpsy opened this issue Jul 21, 2024 · 1 comment · Fixed by #216

Comments

@Numpsy
Copy link
Contributor

Numpsy commented Jul 21, 2024

When testing #214 I got this in my console (Windows 10 with windows terminal):

image

i.e. it printed the analyzer suggestion in blue, and then left the console colour set to blue such that the next prompt was blue.

I wonder whether

member private _.ResetColor() = Console.ForegroundColor <- origColor
should be writing out the escape codes to reset the colour rather than just setting Console.ForegroundColor ?

Maybe it'd also be fixed by #180 though, I haven't tested it.

@dawedawe
Copy link
Contributor

Hey @Numpsy,
thanks for making us aware of this. I'll try to take a look at the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants