diff --git a/CHANGELOG.md b/CHANGELOG.md index 8690aac..41d1b56 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [0.26.0] - 2024-05-15 + +### Changed + +* [Emit Analyzer Errors in the MSBuild Canonical Error Format](https://github.com/ionide/FSharp.Analyzers.SDK/pull/208) (thanks @Numpsy!) +* [Update Structured Logger libraries](https://github.com/ionide/FSharp.Analyzers.SDK/pull/211) (thanks @nojaf!) +* Update FSharp.Compiler.Service and FSharp.Core to the .NET SDK 8.0.300 release versions + ## [0.25.0] - 2024-02-14 ### Changed diff --git a/Directory.Packages.props b/Directory.Packages.props index b7845c4..8a87a29 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -5,18 +5,18 @@ - - + + - + - + diff --git a/src/FSharp.Analyzers.SDK/ASTCollecting.fs b/src/FSharp.Analyzers.SDK/ASTCollecting.fs index 88b8a41..d93f396 100644 --- a/src/FSharp.Analyzers.SDK/ASTCollecting.fs +++ b/src/FSharp.Analyzers.SDK/ASTCollecting.fs @@ -25,14 +25,6 @@ module ASTCollecting = | SynArgPats.Pats ps -> ps | SynArgPats.NamePatPairs(pats = xs) -> xs |> List.map (fun (_, _, pat) -> pat) - /// A pattern that collects all patterns from a `SynSimplePats` into a single flat list - let (|AllSimplePats|) (pats: SynSimplePats) = - let rec loop acc pat = - match pat with - | SynSimplePats.SimplePats(pats = pats) -> acc @ pats - - loop [] pats - type SyntaxCollectorBase() = abstract WalkSynModuleOrNamespace: path: SyntaxVisitorPath * SynModuleOrNamespace -> unit default _.WalkSynModuleOrNamespace(_, _) = () @@ -493,9 +485,9 @@ module ASTCollecting = match s with | SynMemberDefn.AbstractSlot(slotSig = valSig) -> walkValSig nextPath valSig | SynMemberDefn.Member(binding, _) -> walkBinding nextPath binding - | SynMemberDefn.ImplicitCtor(attributes = AllAttrs attrs; ctorArgs = AllSimplePats pats) -> + | SynMemberDefn.ImplicitCtor(attributes = AllAttrs attrs; ctorArgs = pats) -> List.iter (walkAttribute nextPath) attrs - List.iter (walkSimplePat nextPath) pats + walkPat nextPath pats | SynMemberDefn.ImplicitInherit(inheritType = t; inheritArgs = e) -> walkType nextPath t walkExpr nextPath e