From c229e88bf56f0f99be167c1deedbb9de2ae35067 Mon Sep 17 00:00:00 2001 From: dawe Date: Thu, 9 Nov 2023 11:45:29 +0100 Subject: [PATCH 1/2] - don't transform projectpaths to absolute path two times - improve handling of bad --project args --- src/FSharp.Analyzers.Cli/Program.fs | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/FSharp.Analyzers.Cli/Program.fs b/src/FSharp.Analyzers.Cli/Program.fs index 86d4b55..3261997 100644 --- a/src/FSharp.Analyzers.Cli/Program.fs +++ b/src/FSharp.Analyzers.Cli/Program.fs @@ -449,20 +449,13 @@ let main argv = exit 1 | [], Some fscArgs -> runFscArgs client fscArgs ignoreFiles severityMapping |> Async.RunSynchronously | projects, None -> - let runProj (proj: string) = - async { - let project = - if Path.IsPathRooted proj then - proj - else - Path.GetFullPath(Path.Combine(Environment.CurrentDirectory, proj)) - - let! results = runProject client toolsPath project ignoreFiles severityMapping - return results - } + for projPath in projects do + if not (File.Exists(projPath)) then + printError $"Invalid `--project` argument. File does not exist: '{projPath}'" + exit 1 projects - |> List.map runProj + |> List.map (fun projPath -> runProject client toolsPath projPath ignoreFiles severityMapping) |> Async.Sequential |> Async.RunSynchronously |> Array.choose id From ba75698d2724b860a8dd788e744014b63502ba54 Mon Sep 17 00:00:00 2001 From: dawe Date: Thu, 9 Nov 2023 11:48:52 +0100 Subject: [PATCH 2/2] add changelog entry --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 578fb01..d70e4bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [Unreleased] + +### Fixed +* [--project value should be tested if path exists](https://github.com/ionide/FSharp.Analyzers.SDK/issues/141) (thanks @dawedawe!) + ## [0.19.0] - 2023-11-08 ### Changed