Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option "data" is overriden #28

Open
Mishurin opened this issue Feb 1, 2020 · 3 comments
Open

Option "data" is overriden #28

Mishurin opened this issue Feb 1, 2020 · 3 comments
Labels
Resolution: Needs Investigation This PR or Issue should be investigated from the Stencil team

Comments

@Mishurin
Copy link

Mishurin commented Feb 1, 2020

Would it be possible to enable "data" option?
Seems like it is occupied and overridden internally.
See

renderOpts.data = sourceText;

@Mishurin
Copy link
Author

Mishurin commented Feb 1, 2020

Something like renderOpts.data = opts.data + sourceText;

Then we can make sass injections right from the stencil.config

@michalklim
Copy link

Bumping up. That change would be really helpful when it comes to passing ie dynamic variables to sass files. For now, there is no simple way of doing that.

Maybe you could also consider adding another option like additionalData similar to what webpack sass-loader is doing

If you like one of the approaches I'm more than happy to submit a PR

@splitinfinities
Copy link
Contributor

@michalklim the additionalData approach may be awesome! If you (or anyone else reading this) has capacity to make a PR to provide this for @stencil/sass, I think it'd be awesome. Let me know how I can help.

@rwaskiewicz rwaskiewicz added Resolution: Needs Investigation This PR or Issue should be investigated from the Stencil team and removed Feature: Enhancement labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Investigation This PR or Issue should be investigated from the Stencil team
Projects
None yet
Development

No branches or pull requests

4 participants