Skip to content
This repository has been archived by the owner on Apr 2, 2018. It is now read-only.

Can't download clean 1.2.4, always downloads nightly #29

Open
spaceagegroop opened this issue Apr 6, 2016 · 0 comments
Open

Can't download clean 1.2.4, always downloads nightly #29

spaceagegroop opened this issue Apr 6, 2016 · 0 comments

Comments

@spaceagegroop
Copy link

I'm trying to download stable 1.2.4 from the ionic bower repo using a bower.json file. However, it consistently downloads 1.2.4-nighlty-* (which breaks my layout and cancel modal button styling) instead of just clean 1.2.4 even if I specify the following.

{
    "name": "mypackage",
    "private": true,
    "dependencies": {
        "bower-ionic": "driftyco/ionic-bower#v1.2.4"
    }
}

The problem seems to come from some lines (example line 6) being commented out in the _mixins.scss file:

// Button Mixins
// --------------------------------------------------

@mixin button-style($bg-color, $border-color, $active-bg-color, $active-border-color, $color) {
  border-color: transparent;//$border-color;
  background-color: $bg-color;
  color: $color;

  // Give desktop users something to play with
  &:hover {
    color: $color;
    text-decoration: none;
  }
  &.active,
  &.activated {
    //border-color: transparent;//$active-border-color;
    background-color: $active-bg-color;
    //box-shadow: inset 0 1px 4px rgba(0,0,0,0.1);
  }
}

Note that specifying v1.1.1 gives me a clean 1.1.1 version, not a nightly and doesn't have any problems in terms of layout. Also, I could swear for a while I had v1.2.0 and things were perfect but now even if I specify v1.2.0, the nightly is installed.

I get the following output during install, note the version mismatch bit:

bower bower-ionic#v1.2.4 not-cached git://github.com/driftyco/ionic-bower.git#v1.2.4
bower bower-ionic#v1.2.4 resolve git://github.com/driftyco/ionic-bower.git#v1.2.4
bower bower-ionic#v1.2.4 download https://github.com/driftyco/ionic-bower/archive/v1.2.4.tar.gz
bower bower-ionic#v1.2.4 extract archive.tar.gz
bower bower-ionic#v1.2.4 mismatch Version declared in the json (1.2.4-nightly-1917) is different than the resolved one (1.2.4)
bower bower-ionic#v1.2.4 invalid-meta ionic is missing "ignore" entry in bower.json
bower bower-ionic#v1.2.4 resolved git://github.com/driftyco/ionic-bower.git#1.2.4
bower bower-ionic#v1.2.4 install bower-ionic#1.2.4
bower-ionic#1.2.4 bower_components\bower-ionic
├── angular#1.4.3
├── angular-animate#1.4.3
├── angular-sanitize#1.4.3
└── angular-ui-router#0.2.13

The file ionic.js always shows "Ionic, v1.2.4-nightly-1917". Am I doing something wrong or is there something up with the bower repo?

Sorry for the double post from the ionic forum but I haven't received any response and thought it is probably more appropriate to post here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant