Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Cannot generate app-shell (Angular) #225

Open
praywave opened this issue Apr 5, 2020 · 1 comment
Open

bug: Cannot generate app-shell (Angular) #225

praywave opened this issue Apr 5, 2020 · 1 comment

Comments

@praywave
Copy link

praywave commented Apr 5, 2020

Bug Report

Ionic version:
[x] 5.x

Current behavior:
Command ng generate app-shell in "fresh" Ionic gives error:

Schematic input does not validate against the Schema: {}
Errors:

  Data path "" should have required property 'clientProject'.

Expected behavior:

User should be able to exec ng generate app-shell when he chose Angular during the generation of a new Ionic application

Ionic info:

Ionic:

   Ionic CLI                     : 6.0.1 (/usr/local/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.0.7
   @angular-devkit/build-angular : 0.803.26
   @angular-devkit/schematics    : 8.3.26
   @angular/cli                  : 8.3.26
   @ionic/angular-toolkit        : 2.2.0

Utility:

   cordova-res                          : not installed
   native-run (update available: 1.0.0) : 0.3.0

System:

   NodeJS : v13.11.0 (/Users/test/.nvm/versions/node/v13.11.0/bin/node)
   npm    : 6.14.4
   OS     : macOS Catalina
@liamdebeasi liamdebeasi transferred this issue from ionic-team/ionic-framework Apr 6, 2020
@mhartington
Copy link
Contributor

Mmm not even sure how you managed to get that far 😄

$ ng g app-shell
    Prerequisite for app shell is to define a router-outlet in your root component.
Prerequisite for app shell is to define a router-outlet in your root component.

The built in app-shell schematic from angular doesn't appear to work out of the box with ionic since it looks for a router-outlet and not an ion-router-outlet.

A feature request could be made here to rework the app-shell schematic to support ionic apps.
A pull request would be greatly appreciated to any community member that wants to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants