Sync jparse/ with some important updates #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused code (that we thought might be needed but seem to not) was removed. Extra sanity checks were added to a function. A file was renamed and this was done here as well to match that. The CHANGES.md file was corrected to have a missing release so that there's no confusion on the jump in release numbers.
|
Sorry about this! I might add that the bug report script a while back was updated in jparse with some useful changes. I can look into what those were (it happened in more than one edit) and it might be that they could be o use here too. But only if you want. Trying to fix the script with the website and if all is good I'll be done for the day. |
|
The updates involved, now that I think on it, some changes that make it easier to parse the bug report log. That might be worth doing? |
Improved jparse_bug_report.sh. A similar change was done in bug_report.sh but this is not in this commit. The changes should help parse the log better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused code (that we thought might be needed but seem to not) was removed.
Extra sanity checks were added to a function.
A file was renamed and this was done here as well to match that.
The CHANGES.md file was corrected to have a missing release so that there's no confusion on the jump in release numbers.