Sync jparse/ with jparse repo w/fixes #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes some important bug fixes, namely that some codepoints that were rejected are no longer rejected as later Unicode standards allow them. This means that the JSONTestSuite (https://github.com/nst/JSONTestSuite) files now completely pass jparse. The CODE_OF_CONDUCT.md was removed from jparse/ as it referred to the IOCCC judges which is not correct. Until a better way of doing this is derived, this file no longer exists. To be clear the mkiocccentry CODE_OF_CONDUCT.md still exists!
... these are cosmetic changes.
Links were incorrect. Link to FAQs about certain things. Stress to pay attention to the rules and guidelines, and especial attention to rule 17 (these are all linked to). The links refer to the temp-test-ioccc website so once the Great Fork Merge happens these links will also have to be updated to refer to the official IOCCC website.
A missing string in jparse.h/jparse.y was added. Added extra sanity checks to jstrencode and jstrdecode (to do with NULL pointers). Comments in jparse.l were updated as well. jparse.3 fixes and updates.
|
Given the missing string and the sanity checks I decided it would be worth making another pull request here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missing string in jparse.h/jparse.y was added.
Added extra sanity checks to jstrencode and jstrdecode (to do with NULL
pointers).
Comments in jparse.l were updated as well.
jparse.3 fixes and updates.