Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to use Doorbird client library #100

Open
ihrigb opened this issue Nov 28, 2023 · 3 comments · May be fixed by #107
Open

Suggestion to use Doorbird client library #100

ihrigb opened this issue Nov 28, 2023 · 3 comments · May be fixed by #107

Comments

@ihrigb
Copy link

ihrigb commented Nov 28, 2023

I'd like to suggest to move this implementation to my client library for the Doorbird API: https://github.com/ihrigb/node-doorbird. I will try to find some time to work on a proposal during the holidays.

@Schmakus
Copy link
Collaborator

Good idea!

@Schmakus
Copy link
Collaborator

Hi, is it possible to get the favourites? I se only set favourite and update favourite, but how can I update one if I don't know the id of them?
Second question: for doorbell and motion, no favourites are needed anymore, correct?

@ihrigb
Copy link
Author

ihrigb commented Dec 20, 2023

The library has a listFavorites method (https://github.com/ihrigb/node-doorbird/blob/main/src/index.ts#L534). Seems like I forgot to document this in the README.
For your second question: The library comes with a UDP socket that listens on either of Doorbird's UDP ports and can handle incoming broadcasts (for ring and motion events). The problem sometimes is that this library is often used in Docker environments with a bridge network. In these circumstances, UDP broadcast messages are not forwarded to the container and hence the message will not reach the socket. For that, either another network configuration (host or macvlan) are necessary, or the registration of a favorite is handy.

@ihrigb ihrigb linked a pull request Dec 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants