-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Initial Monorepo #1551
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notaphplover
reviewed
Jan 5, 2024
At the end we never merged this. Too many changes in a single PR, let's go step by step in the new monorepo instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since it takes a lot of work to adapt the tools/scripts and match dependencies between projects, I think it may be best to migrate just this project and set up the infrastructure in this PR and migrate the other projects in subsequent PRs. Moving the git history alone has proven to be the easy part (I have done it, but didn't want to go through with the full migration right away). Essentially, we move all files in the repo to
/apps/<repo-name>
, commit, add it as a remote in this repo, andgit merge <repo-name>/<branch> --allow-unrelated-histories
. The hard (tedious?) part is to rework thepackage.json
and resolve dependency conflicts.I took the liberty of trying out turborepo here, since it only adds to the workspace experience. A free and painless addition, it turns out.
What is done here:
apps/*
(for public stuff) andpackages/*
(for internal stuff)tsconfig
sapps/inversify
publish-please
(should probably re-add but want to also considerchangesets
)README.md
CONTRIBUTING.md
LICENSE
Related Issue
#1550
Motivation and Context
Monorepos are easier to maintain, as has been discussed in #1550 and on the Inversify Discord server. Turborepo allows for faster CI and developer experience without forcing us into a system other than workspaces.
tsup
allowed for a simplification of the build and the tsconfig setup (tsup doesn't support amd so I leftbuild:amd
intact). I hope this simplification makes things more approachable.How Has This Been Tested?
inversify
test
script.inversify
build
script.Types of changes
Checklist: