Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchase Price can not be empty when creating new stock item #538

Closed
cbenhagen opened this issue Sep 27, 2024 · 3 comments · Fixed by #539
Closed

Purchase Price can not be empty when creating new stock item #538

cbenhagen opened this issue Sep 27, 2024 · 3 comments · Fixed by #539
Labels
bug Something isn't working

Comments

@cbenhagen
Copy link

When creating a new stock item the purchase price can not be empty and defaults to 0 which is not desirable.

Image

Tested on latest master branch (6c0b3cc)
SchrodingersGat added a commit that referenced this issue Sep 27, 2024
@SchrodingersGat
Allow null values for decimal fields
6f79b08 
- fixes #538
@SchrodingersGat SchrodingersGat added the bug Something isn't working label Sep 27, 2024
@SchrodingersGat SchrodingersGat mentioned this issue Sep 27, 2024
Merged
@SchrodingersGat
Copy link
Member

@cbenhagen thanks for reporting - fix incoming in #539

@cbenhagen
Copy link
Author

Thanks @SchrodingersGat! #539 should solve the first part of this issue. I should have maybe created a second one for nullable fields defaulting to 0. When the dialog opens the field should default to an empty string if this is nullable right?

SchrodingersGat added a commit that referenced this issue Sep 27, 2024
@SchrodingersGat
Allow null values for decimal fields (#539)
538a3d6 
* Allow null values for decimal fields

- fixes #538

* Update release notes

* Fix initial value
@cbenhagen
Copy link
Author

@SchrodingersGat thanks again for the quick fix!! I just recompiled the app and it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow null values for decimal fields inventree/inventree-app
2 participants
@cbenhagen @SchrodingersGat