Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the chart using github pages #133

Open
egabancho opened this issue Nov 29, 2024 · 5 comments
Open

Publish the chart using github pages #133

egabancho opened this issue Nov 29, 2024 · 5 comments

Comments

@egabancho
Copy link
Member

It'd be nice to pull this chart directly without cloning the repository. It seems that using GitHub pages is a sensible solution, even document on helm's docs: https://helm.sh/docs/howto/chart_releaser_action/

I know we will probably make breaking changes, always for the better, but that's what version 0.x.y is for, although we will try to be nice.

cc-ing @lindhe

@lindhe
Copy link
Contributor

lindhe commented Dec 2, 2024

I agree 100%! Unless we publish the Helm chart, I don't understand why it exists. The whole point of Helm is to be a package manager, but our package has not been published so people cannot install it (easily).

I know we will probably make breaking changes, always for the better, but that's what version 0.x.y is for, although we will try to be nice.

OMG yes!! 😅 Even with the chart being unpublished, it's a pain in the butt that we never increment the chart version number. It makes it very hard to keep track of which features are present in an installed release or not. And to publish it, we pretty much must start incrementing the version number on every change.

I've been wanting this since I first started working on the Helm chart, so I'm all with you. Just as you say, major version 0 specifically allows breaking changes so I see on reason to not increment it regularly. Publishing the chart does not mean it's a stable release.

I think we need to have @slint and/or @ntarocco on board with us to approach this issue, since it primarily concerns infrastructure and release process rather than code changes.

@ntarocco
Copy link
Contributor

ntarocco commented Dec 2, 2024

Yes, I agree that the chart should be published with a correct version and following SemVer. We are not using this chart directly in our installations, we will have to decide what is the current first version.

@egabancho
Copy link
Member Author

There is already a "version" . We can use that as the first one or change it to 0.1.0. I don't have a strong preference here.

Do we like the idea of publishing the chart using GitHub pages?

@lindhe
Copy link
Contributor

lindhe commented Dec 2, 2024

There is, but it has not been bumped in ages. It should be bumped on every chart change. It must be, if we shall publish the chart.

I think it sounds good, but I have no authority over the inveniosoftware organization's GitHub, so my vote does not count. 🙃

@slint
Copy link
Member

slint commented Dec 2, 2024

IMHO, depends how we feel about the charts state. If we keep the 0.x.y convention where every minor can be breaking, then I think we also make our lives a bit easier in terms of communicating the "official" release of the charts and have some leeway. In that case, bumping to v0.3.0, and setting up a GH-pages publishing sounds good to me.

If you're using this in production already, v1.0.0 is also fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants