Unescape search result page title and set via textContent
#9965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
changed the title
textContenttextContent
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9965 +/- ##
==========================================
+ Coverage 16.06% 17.11% +1.05%
==========================================
Files 90 89 -1
Lines 4769 4755 -14
Branches 832 831 -1
==========================================
+ Hits 766 814 +48
+ Misses 3480 3431 -49
+ Partials 523 510 -13 ☔ View full report in Codecov by Sentry. |
cdrini
requested changes
Nov 4, 2024
| @@ -78,7 +80,7 @@ export function initSearchFacets(facetsElem) { | |||
| facetsElem.replaceWith(newFacetsElem) | |||
| hydrateFacets() | |||
|
|
|||
| document.title = data.title | |||
| setTitle(data.title) | |||
There was a problem hiding this comment.
Can we avoid html-escaping the title entirely on the python side, where data is created? Then we can do document.title = data.title, and avoid the lodash dependency.
| @@ -88,6 +90,10 @@ export function initSearchFacets(facetsElem) { | |||
| } | |||
| } | |||
|
|
|||
| function setTitle(title) { | |||
| const titleElem = document.querySelector('title') | |||
There was a problem hiding this comment.
I think modifying document.title is more idiomatic for change the title; was there a reason you switch to querySelector?
cdrini
added
Priority: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9787
Unescapes the search result title, then updates the title via the
titleelement'stextContentproperty.Technical
Testing
Screenshot
Stakeholders