-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified "Read" Button Dropper #5831
Comments
Related request from a patron: |
@rebecca-shoptaw Hi thanks for your tips! Flex grow works :D As far as the list styling the issue is that I can see in my element inspector that my styling is being overwritten by other rules; other than that it's being applied correctly. |
@SivanC Aha! You want to make sure you're applying it to the full list Edit: Hmm looks like If that doesn't work, there are some specificity tricks you can try, but fingers crossed that does the trick! |
@rebecca-shoptaw Unfortunately the reason I had it on the Here's the full HTML right now:
|
@SivanC Thank you!! Ok, it looks like the styling is being inherited because the parent element of all of this has a This means you'll want to use selector specificity to overrule the existing openlibrary/static/css/components/read-panel.less Lines 164 to 167 in 9fc1f69
So it seems that the simplest course of action would be to add a few lines like this directly above those:
Effectively you're saying that while all There may be a more elegant way to do this, but this should do the trick! You could also try swapping out the |
@rebecca-shoptaw I was about to respond that nothing I tried was working ... until! I noticed that both
No more bullet points! :D Also worked to overwrite the negative margins causing the button to be misaligned. |
Update as of 7/26/24 design call, clarifying some questions surrounding dropper content:
|
We have a lot of read-y actions a user can perform; designing these as a dropdown would allow us to expose these options in more places; eg search results, carousels; without taking up a bunch of space.
Options
Borrow / Read, Listen, Search Inside, Download, Locate (meaning check nearby libraries)
Description, Patron Story
Turns the read button into a drop-down menu with more options
saves real estate on the page by grouping similar options (downloads, etc)
all patrons and stakeholders of the books page
Preferably everything is managed using
details
html element and no js is required, all css.Relevant Designs
https://www.figma.com/file/dYQkIJOJeMo9hx7ewZQH9x/Open-Library%3A-Design-System-%26-Component-Library?type=design&node-id=601-199&mode=design&t=giRw2crBrKKYkWGi-0
Problem Statement
Proposal & Constraints
Actions in dropdown (WIP):
Additional context
Stakeholders
@mekarpeles @cdrini
The text was updated successfully, but these errors were encountered: