Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Richer UI install for PWA on Chrome #8929

Open
7 tasks
RayBB opened this issue Mar 20, 2024 · 19 comments · May be fixed by #10143
Open
7 tasks

Use Richer UI install for PWA on Chrome #8929

RayBB opened this issue Mar 20, 2024 · 19 comments · May be fixed by #10143
Assignees
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Mobile Mobile & Progressive Web App Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Mar 20, 2024

Chrome supports a richer install UI for progressive web apps.

We can include screenshots (both mobile and desktop) and a description.

Img of how it looks

Describe the problem that you'd like solved

Use these new features to improve the experience.

Proposal & Constraints

Your task:

  • Find/write a description
  • Find/take screenshots for mobile
  • Find/take screenshots for desktop
  • Post to Slack asking for feedback on description/screenshots
  • Upload screenshots (probably to internet archive - ask Mek)
  • Create a PR updating the manifest with the new informations
  • Provide screenshots of the new install UI working (if you can't get it working locally ask and we can put it on testing)

Note: this is not compatible with Firefox

If you would like to work on this please just say you'd like to work on it and get started. I'll assign it to you when I get a chance.

Additional context

Stakeholders

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Module: Mobile Mobile & Progressive Web App Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] labels Mar 20, 2024
@Sameer-Pal
Copy link

Hi, @RayBB I'd like to work on that

@RayBB
Copy link
Collaborator Author

RayBB commented Mar 23, 2024

@Sameer-Pal that would be wonderful!

@RayBB
Copy link
Collaborator Author

RayBB commented Apr 2, 2024

@Sameer-Pal please let me know if you're still working on this. Otherwise we can give someone else a chance to work on it.

@Sameer-Pal
Copy link

Hi, @RayBB
I'am working on it,
I'll deliver the PR shortly!

@Sameer-Pal
Copy link

Sameer-Pal commented Apr 3, 2024

Hi, @RayBB It's been written to clone using SSH not using HTTPS but it's not working that way!
Bcz, key is not provided
Should i run it using HTTPS ?
Screenshot (716)

@scottbarnes
Copy link
Collaborator

@Sameer-Pal, it may be the case that you need to add your SSH key to GitHub. If you've not tried the steps in Permission denied while cloning, they may be worth checking out.

@Sameer-Pal Sameer-Pal removed their assignment Apr 3, 2024
@OfcPeriwinkle
Copy link

@Sameer-Pal, did you mean to remove your assignment from this issue or are you still working on a PR?

I might be interested in taking this over if you are looking to hand it off.

@RayBB
Copy link
Collaborator Author

RayBB commented Apr 12, 2024

@OfcPeriwinkle please go ahead and try. You're assigned now.

@OfcPeriwinkle
Copy link

Just wanted to post an update since it's been a little bit. I submitted a volunteer form a few days ago and I'm just waiting on the Slack invite. I have a draft description and some screenshots for review once I'm able to join the channel.

I tested out the manifest locally with the desktop screenshots I have and everything looks like what we'd expect. I'm not too sure how to go about testing the mobile install UI locally so if someone has an idea of how to do that I'm all ears!

@RayBB
Copy link
Collaborator Author

RayBB commented Apr 24, 2024

@mekarpeles can you check the volunteer form?
@OfcPeriwinkle please share your draft here. For mobile you can try gitpod and access the address you get from your phone.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Apr 25, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented May 7, 2024

@OfcPeriwinkle are you still working on this?

@OfcPeriwinkle
Copy link

@RayBB Just started a new job so I've been busy with onboarding. I'll post what I have for review once I get some time this week.

@OfcPeriwinkle
Copy link

Apologies for the delay, here are the draft screenshots and description.

Description

  • "An open, editable library catalog for every book published. Read, borrow, and discover more than 3M books for free."

Landing Page

  • Label
    • "Read free library books online. Millions of books available through Controlled Digital Lending."

Search

  • Label
    • "Search for books, authors, and more."

Student Library

  • Label
    • "Utilize a school library designed for a K-12 audience."

Trending

  • Label
    • "See which titles are currently trending."

Lists

  • Label
    • "Explore and create book lists."

@RayBB
Copy link
Collaborator Author

RayBB commented May 20, 2024

@OfcPeriwinkle I think these look pretty fantastic. I'm going to see if we can get any community feedback.
However, I think you can open a PR now as the basics of these are probably going to stay the same.

Thanks!

@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Needs: Response Issues which require feedback from lead labels May 20, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented May 20, 2024

@mekarpeles @cdrini do either of you wanna provide feedback this?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 21, 2024
@RayBB RayBB removed the Needs: Response Issues which require feedback from lead label May 26, 2024
@jimchamp jimchamp removed the Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] label May 28, 2024
@jimchamp jimchamp added Needs: Review Assignee Issues that may have been abandoned by assignees Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Module: Mobile Mobile & Progressive Web App Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Good First Issue Easy issue. Good for newcomers. [managed] Module: Mobile Mobile & Progressive Web App Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Needs: Review Assignee Issues that may have been abandoned by assignees labels May 28, 2024
@cdrini
Copy link
Collaborator

cdrini commented Sep 11, 2024

Taking a look at this now; those look great @OfcPeriwinkle ! We have a similar set of screenshots we use for the play store here: https://github.com/internetarchive/openlibrary/blob/59c8fa5ce588020633ee0f16d23aa052d8a43ea9/conf/twa/Play_Store_SS.mockup . It has screenshots for a few of the places you have taken screenshots, but they're a bit outdated. Would you be able to update the .mockup file with screenshots for the current site? And use the same format to create new screenshots for desktop.

For the description, let's copy it from the play store to be consistent: Open Library is an open, editable library catalog, building towards a web page for every book ever published. Read, borrow, and discover more than 3M books for free.

@cdrini cdrini removed the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Sep 11, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Nov 5, 2024

@OfcPeriwinkle I unassigned you as we haven't heard back in a while. Please let me know if you decide to work on it again.
Until then hopefully someone else can take a look.

@DachiCharkviani
Copy link

DachiCharkviani commented Dec 3, 2024

Hello, I would like to be assigned to this issue and try to solve it!

@RayBB
Copy link
Collaborator Author

RayBB commented Dec 3, 2024

@DachiCharkviani you're assigned. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Mobile Mobile & Progressive Web App Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants