Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

? character is not searchable #10046

Open
seabelis opened this issue Nov 19, 2024 · 3 comments · May be fixed by #10099
Open

? character is not searchable #10046

seabelis opened this issue Nov 19, 2024 · 3 comments · May be fixed by #10099
Assignees
@ronibhakta1
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Response Issues which require feedback from lead Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]

Comments

@seabelis
Copy link
Collaborator

Problem

Searching for the ? character returns no results.

Screenshot 2024-11-19 at 18 59 40 Related to #7568

Reproducing the bug

  1. Go to ...openlibrary.org
  2. Do ...enter ? into the search box

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@seabelis seabelis added Type: Bug Something isn't working. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 19, 2024
@ronibhakta1
Copy link
Contributor

hey @seabelis i'm new with open source contribution here, as of now i have check the need with the support for the "?" like previous addons were made for "@" and "#" i have added the support to "?" for the search. the code fix is added on 10046/fix/question-char-not-searchable branch you can check and merge it :)

@ronibhakta1 ronibhakta1 mentioned this issue Nov 20, 2024
Closed
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 21, 2024
@mekarpeles mekarpeles added Theme: Search Issues related to search UI and backend. [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 25, 2024
@cdrini
Copy link
Collaborator

cdrini commented Nov 27, 2024

Howdy, thanks @ronibhakta1 and great idea using that other one as a template! Assigning to you

@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Nov 27, 2024
@ronibhakta1 ronibhakta1 linked a pull request Nov 28, 2024 that will close this issue
Open
@ronibhakta1
Copy link
Contributor

ronibhakta1 commented Nov 29, 2024 •
edited
Loading

@cdrini @mekarpeles can you check the changes which are made as per asked, can you check that I have updated it 6 days ago

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronibhakta1 ronibhakta1

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Response Issues which require feedback from lead Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
4 participants
@mekarpeles @cdrini @seabelis @ronibhakta1