Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk space pause is not working #69

Open
NGTmeaty opened this issue Jul 3, 2024 · 3 comments
Open

Disk space pause is not working #69

NGTmeaty opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@NGTmeaty
Copy link
Collaborator

NGTmeaty commented Jul 3, 2024

It appears that something is resetting the pause state immediately after the disk space pause, causing it to continue crawling when we no longer have space.

@NGTmeaty NGTmeaty added the bug Something isn't working label Jul 3, 2024
@NGTmeaty NGTmeaty self-assigned this Jul 3, 2024
@equals215
Copy link
Member

@NGTmeaty you wanna debug this yourself? Asking cause you assigned it to yourself

@CorentinB
Copy link
Collaborator

It's strange, it looks like it works, but not for all workers. Right now I have a crawl that is displaying the low disk space pausing message, and 1 worker out of 500 is still crawling. There is no reason (looking at the queue) for the other workers to not crawl, so I guess the pausing kinda works? But not for all workers.

@equals215
Copy link
Member

This is linked with the"problem" that a worker in a crawl retry loop will stay in that loop and not be paused.
Pause check at worker level is in it's main event loop but when the crawl.Capture() function is called the worker doesn't have any possibility to pause the crawl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants