-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(style) - Refactor timeout of hiding subnav using js #992
Conversation
🦋 Changeset detectedLatest commit: c222ddb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ilo-ui-twig-develop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ilo-ui-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ilo-ui-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @justintemps this seems to look good on my local, I think it looked a bit off cause of the timing set here, I noticed that you have added 150ms for the timeout function, The transition takes around 225ms. The search had the proper timing set. |
Hey @Shashika6, were you able to replicate this problem in Storybook? |
Will move it back to ready for review after testing in bb8 |
Fixes #968
Notes :-
Fix :-