Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style) - Refactor timeout of hiding subnav using js #992

Closed
wants to merge 2 commits into from

Conversation

Shashika6
Copy link
Contributor

Fixes #968

Notes :-

  • Currently there is an odd animation when closing the subnav

Fix :-

  • Refactor javascript set timeout function to sync timing with the transition

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: c222ddb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ilo-org/styles Patch
@ilo-org/react Patch
@ilo-org/twig Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Shashika6 Shashika6 marked this pull request as draft April 25, 2024 20:43
@Shashika6 Shashika6 self-assigned this Apr 25, 2024
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for ilo-ui-twig-develop ready!

Name Link
🔨 Latest commit c222ddb
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig-develop/deploys/662ac3bf85ab0c0008e15e81
😎 Deploy Preview https://deploy-preview-992--ilo-ui-twig-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for ilo-ui-twig ready!

Name Link
🔨 Latest commit c222ddb
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig/deploys/662ac3bf1dc65a000881afab
😎 Deploy Preview https://deploy-preview-992--ilo-ui-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for ilo-ui-react ready!

Name Link
🔨 Latest commit c222ddb
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-react/deploys/662ac3bf8376550008b77d19
😎 Deploy Preview https://deploy-preview-992--ilo-ui-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shashika6
Copy link
Contributor Author

Shashika6 commented Apr 25, 2024

Hey @justintemps this seems to look good on my local, I think it looked a bit off cause of the timing set here, I noticed that you have added 150ms for the timeout function, The transition takes around 225ms. The search had the proper timing set.

@Shashika6 Shashika6 requested a review from justintemps April 25, 2024 20:50
@Shashika6 Shashika6 marked this pull request as ready for review April 25, 2024 20:50
@justintemps
Copy link
Member

Hey @Shashika6, were you able to replicate this problem in Storybook?

@Shashika6
Copy link
Contributor Author

Will move it back to ready for review after testing in bb8

@Shashika6 Shashika6 marked this pull request as draft April 30, 2024 12:44
@Shashika6 Shashika6 closed this May 5, 2024
@justintemps justintemps deleted the fix/style/navigation branch July 10, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix odd transition in Navigation sub menu
2 participants