Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Update components to sync with Twig #1274

Open
13 tasks
justintemps opened this issue Dec 9, 2024 · 0 comments
Open
13 tasks

React: Update components to sync with Twig #1274

justintemps opened this issue Dec 9, 2024 · 0 comments
Assignees

Comments

@justintemps
Copy link
Member

Overview

This provides an inventory of components in React that aren't working as expected either because they need to be synced with the versions in Twig or just because they're broken and need to be fixed. Most of these are cosmetic so this ticket should be fixable with a single PR.

Importantly, however, each of these fixes ought to be accompanied by a test.

This issue resolves #1264

User Interface

Button

  • Docs page is broken
  • Icons don't work

Cards

Card Group

  • Rename cards prop to group for consistency with Twig

Data Card

  • When in two columns, image should be on one side, content on the other
  • Buttons should be small primary

Detail Card

  • Add isVideo prop to show video player in top left corner

FactList Card

  • Text and bullets should be white when theme is set to dark

Feature Card

  • Add isVideo prop to show video player in top left corner

Text Card

  • Should use correct kind of button

Content

Accordion

  • Fix, this is broken in React

Heading

  • Fix, this are completely broken and don't correspond to designs or styles in RichText

Hero

  • caption is broken, there's no icon or tooltip displayed

Media

Video

  • Video player is missing volume icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants