Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig/React: Video Player is missing volume icon #1273

Open
justintemps opened this issue Dec 9, 2024 · 11 comments
Open

Twig/React: Video Player is missing volume icon #1273

justintemps opened this issue Dec 9, 2024 · 11 comments

Comments

@justintemps
Copy link
Member

The icon is missing in both libs

image
@Srishtihere
Copy link

can I work on this issue ?

@justintemps
Copy link
Member Author

Hey @Srishtihere sure thing! We need to use the sound on / sound off icons here

https://github.com/international-labour-organization/designsystem/tree/develop/packages/icons/src/svg

image

This may be trickier than it looks.

@Srishtihere
Copy link

thanks, I think i can try working on this and update you tomorrow

@Srishtihere
Copy link

Hi I see the repo is too big and I am unable to clone it so any solutions for that ?

@justintemps
Copy link
Member Author

@Srishtihere the repo is pretty big, but I've never had any trouble cloning it. What issue are you having specifically?

@Srishtihere
Copy link

hey the issue is solved now working on the icon issue, thanks

@Srishtihere
Copy link

Screenshot 2024-12-12 235901
Hi, can you help me with this? Can't seem to debug this

What possible plugin/library am I missing? This is what I get on the console


Screenshot 2024-12-13 000033

@justintemps
Copy link
Member Author

@Srishtihere Did you build the libs first?

pnpm build:libs

@justintemps
Copy link
Member Author

@Srishtihere make sure to review the contribution guidelines, which have a list of the commands you need to run to install/build/run things:

https://github.com/international-labour-organization/designsystem/blob/develop/contributing.md

@Srishtihere
Copy link

@Srishtihere Did you build the libs first?

pnpm build:libs

Hey I did but same error, I followed the commands in the contributor.md file, this is what happens -
Screenshot 2024-12-13 233550

@justintemps
Copy link
Member Author

@Srishtihere weird, I've never seen this before. Are you using the right version of node and pnpm?

The latest version of the develop branch has an improved build workflow that may fix this. Try pulling down a fresh version of develop, cut a new branch, and do the following:

pnpm install
pnpm twig:dev:docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants