-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twig/React: Video Player is missing volume icon #1273
Comments
can I work on this issue ? |
Hey @Srishtihere sure thing! We need to use the sound on / sound off icons here This may be trickier than it looks. |
thanks, I think i can try working on this and update you tomorrow |
Hi I see the repo is too big and I am unable to clone it so any solutions for that ? |
@Srishtihere the repo is pretty big, but I've never had any trouble cloning it. What issue are you having specifically? |
hey the issue is solved now working on the icon issue, thanks |
@Srishtihere Did you build the libs first?
|
@Srishtihere make sure to review the contribution guidelines, which have a list of the commands you need to run to install/build/run things: https://github.com/international-labour-organization/designsystem/blob/develop/contributing.md |
Hey I did but same error, I followed the commands in the contributor.md file, this is what happens - |
@Srishtihere weird, I've never seen this before. Are you using the right version of node and pnpm? The latest version of the
|
The icon is missing in both libs
The text was updated successfully, but these errors were encountered: